Skip to content

WebAPI: Add resolutions and spatialUnits to mldataset #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 21, 2025
Merged

WebAPI: Add resolutions and spatialUnits to mldataset #1177

merged 7 commits into from
Oct 21, 2025

Conversation

@clarasb
Copy link
Collaborator

@clarasb clarasb commented Aug 12, 2025 •
edited
Loading

This PR:

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@clarasb clarasb requested a review from forman August 12, 2025 15:55
@clarasb clarasb changed the title add resolutions and spatialUnits to mldataset WebAPI: Add resolutions and spatialUnits to mldataset Aug 12, 2025
@clarasb clarasb mentioned this pull request Aug 12, 2025
Open
forman
forman requested changes Sep 12, 2025
View reviewed changes
Copy link
Member

@forman forman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine, but please write a CHANGELOG entry.

Although the code is covered by at least one test, none of them really asserts the correctness of the new settings. Consider writing a new unit test or enhancing one.

@clarasb clarasb requested a review from forman October 20, 2025 15:02
forman
forman requested changes Oct 20, 2025
View reviewed changes
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually approved, but CI still fails. Please fix.

@clarasb
Copy link
Collaborator Author

clarasb commented Oct 20, 2025

The tests related this PR have been adjusted.

@clarasb clarasb self-assigned this Oct 21, 2025
konstntokas
konstntokas approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@konstntokas konstntokas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.52%. Comparing base (921e831) to head (73abdc4).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
+ Coverage   89.51%   89.52%   +0.01%     
==========================================
  Files         280      280              
  Lines       21659    21661       +2     
==========================================
+ Hits        19387    19391       +4     
+ Misses       2272     2270       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clarasb clarasb merged commit df3e836 into main Oct 21, 2025
5 checks passed
@clarasb clarasb deleted the clarasb-xxx-xcube_viewer_add_zoom_box branch October 23, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@forman forman forman requested changes

@konstntokas konstntokas konstntokas approved these changes

Assignees

@clarasb clarasb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clarasb @forman @konstntokas